Fixes and enhancements to modem rate setting in TDMA node class (!48) · Merge requests · Acomms / ros_acomms · GitLab

Two Factor Authentication (2FA) as been enabled for all git.whoi.edu users. For instructions on how to set up 2FA, follow the instructions on this page, or click here for a step-by-step walk-through.

Once you have 2FA setup, you may need to create an Access Token to pull and push with git. You will not be able to authenticate with git using your password once you enable 2FA. See this link for how to set up and use a Personal Access Token.

The decision to enable 2FA for all users is for added security. Oct 30th, some users experienced account lockout due to bad actors. 2FA will help prevent such incidents in the future. Thank you.

Eric Gallimore requested to merge dev/tdma_match_rate_max_buf into master May 12, 2023

Fixes:

Miniframe rate setting is respected (it was always using rate 1)
If the user attempts to set the bytes_per_[data|mini]frame to a value greater than the modem will accept, the value is clamped to the valid maximum.

Enhancements:

Rates and max number of bytes are not handled using getters/setters. This functionality is largely beneficial for derived TDMA node classes.

Version in package.xml is bumped to 6.1.0